Open
Conversation
Added a period to *.*format(tn= ...
Owner
|
Thanks! But I see that there are two periods now: Could you please remove the upper one? |
Author
|
Ah, sorry! I just realized that the places that I thought periods were needed, were just included above instead of on the new line! I'll let you close this unless you'd like for me to change them all for consistency. |
Owner
|
No worries, and I think it's visually a bit misleading. I think we could leave it as is. It has a bit of those "when you see you old code and cringe" moments ;) I would put the period onto the new line if I wrote it today. Sth like (the backslash shouldn't be needed because of the parentheses.) |
Author
|
👍 sounds good to me. Sorry for the confusion! |
Owner
|
No worries, I appreciate it that you submitted a PR helping to fix it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a period to *.*format(tn= ...