Skip to content

Added network event sanitizers so replay fetch bodies can be enabled#28

Open
indykoning wants to merge 2 commits intomasterfrom
feature/replay-fetch-body
Open

Added network event sanitizers so replay fetch bodies can be enabled#28
indykoning wants to merge 2 commits intomasterfrom
feature/replay-fetch-body

Conversation

@indykoning
Copy link
Copy Markdown
Member

The filtering list have been taken from OpenReplay, and it will only be uses when networkDetailAllowUrls has been filled.
By default it will never record the bodies of urls not in this whitelist.

'mask',
'cart_id',
'postcode',
'city',
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filtering postcode and city but not street and housenumber 🤔 seems kinda useless then no?

Comment thread resources/js/sentry.js
return event;
},
...(integrationsConfig.replay || {}),
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we potentially want to make it possible to hook into this from outside of this package? Same as we did for the beforeSend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants