Skip to content

Fixes and Tweak for AzureAD OAuth #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
binaryoverload wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −3
Open

Fixes and Tweak for AzureAD OAuth #591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a12a10
fix: windows url was broken for URLs with & - use rundll32
binaryoverload Apr 24, 2026
2084294
feat: use a fixed default port so callback urls are predictable
binaryoverload Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cmd/kubectl_token_oauth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func oauthAuth(client *http.Client, input *LoginInput, provider TypedProvider, u
func getCallbackPort() (int, error) {
env := os.Getenv("CATTLE_OAUTH_CALLBACK_PORT")
if env == "" {
return 0, nil // Use random port
return 8888, nil // Default port
}

port, err := strconv.Atoi(env)
Expand Down Expand Up @@ -199,8 +199,10 @@ func openBrowser(openURL string) error {
cmd = "xdg-open"
args = []string{openURL}
case "windows":
cmd = "cmd"
args = []string{"/c", "start", "", openURL}
// rundll32 handles the URL as a single argument; avoids cmd.exe
// interpreting `&` in query strings as a command separator.
cmd = "rundll32"
args = []string{"url.dll,FileProtocolHandler", openURL}
default:
return fmt.Errorf("unsupported platform: %s", runtime.GOOS)
}
Expand Down