Quality pass: build system & infrastructure#95
Merged
dhilgaertner merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
- Fix error masking in build-ghostty.sh: replace blanket `|| true` on zig build with proper exit code capture; add cleanup trap for temp files; guard WUFFS/SIMD copies with explicit file checks; fix ranlib stderr - Add VERSION file as single source of truth for app version; read it in bundle.sh and generate-build-info.sh (emits BuildInfo.version) - Add binary existence check in bundle.sh before bundling - Add `make test` target that discovers all packages with Tests/ dirs - Align mise.toml build task to use `make build` instead of raw swift build - Expand CI: test job loops over all packages; add shellcheck lint job - Expand CONTRIBUTING.md with make test docs and make build guidance - Add header comments to all build scripts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dhilgaertner
force-pushed
the
feature/crow-76-quality-pass-build-infra
branch
from
f801f5e to
33f2616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-ghostty.sh: replace blanket|| trueon zig build with proper exit code capture, add cleanup trap, guard artifact copies with explicit file checksVERSIONfile as single source of truth for app version (read bybundle.shandgenerate-build-info.sh)make testtarget and shellcheck CI job; expand test job to discover all packages with testsmise.tomlbuild task to usemake build; expandCONTRIBUTING.mdwith build/test guidanceRelated Issue
Closes #76
Changes
scripts/build-ghostty.sh— Error handling, cleanup trap, fragility comments, cp/ranlib fixes, header docsscripts/bundle.sh— Binary validation, version fromVERSIONfile, header docs, icon TODOscripts/generate-build-info.sh— Version fromVERSIONfile, emitsBuildInfo.version, header docsVERSION(new) — Single source of truth for app version (0.1.0)Makefile— Addtesttarget (loops over packages withTests/dirs), update helpmise.toml— Align build task tomake build.github/workflows/ci.yml— Multi-package test loop, shellcheck lint jobCONTRIBUTING.md— Expand test/build documentationTesting
make testpasses (3 CrowCore tests)make helpshows updated targetsChecklist
🤖 Generated with Claude Code