Quality pass: app lifecycle & window management#94
Merged
dhilgaertner merged 2 commits intomainfrom Apr 6, 2026
Merged
Conversation
…tests Add structured logging throughout the startup and shutdown sequences so issues are visible in Console.app. Replace silent `try?` calls with proper error handling in Scaffolder, ConfigStore, and the setup wizard flow — setup failures now surface to the user instead of being swallowed. Extract path-traversal and session-name validation into a shared CrowCore.Validation module so the logic is testable and uses URL.standardizedFileURL (resolves symlinks) instead of the weaker NSString.standardizingPath. Other improvements: - Runtime dependency check now includes glab and code, stores missing deps in AppState.missingDependencies for UI consumption - Main window gets minSize constraint (800×500) - center() called before setFrameAutosaveName() so saved frame wins - Config persisted on shutdown to catch unsaved settings changes - Scaffolder legacy migration uses case-insensitive replacement - 16 new tests covering Validation, AppConfig codable, and ConfigStore Closes #63 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The outer Task inherits @mainactor context so appState is accessed safely after awaiting the detached child task's result. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dhilgaertner
force-pushed
the
feature/crow-63-quality-pass-app-lifecycle
branch
from
d28a8e1 to
f35ddcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try?calls with proper error handling in Scaffolder, ConfigStore, and setup wizard — failures now surface to usersCrowCore.Validationmodule usingURL.standardizedFileURL(resolves symlinks)glabandcode, stores missing deps inAppState.missingDependenciesminSizeconstraint, frame autosave ordering fixed, config persisted on shutdownCloses #63
Test plan
make buildcompiles without errorsswift testpasses all 16 new tests (CrowCore + CrowPersistence)🤖 Generated with Claude Code