Quality pass: data persistence / storage#93
Merged
dhilgaertner merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
Fix bugs, improve code quality, add tests, and expand documentation for the CrowPersistence layer. Bug fixes: - SessionRepository.delete() now cascades to terminals (was leaking records) - JSONStore.mutate() holds lock through disk write (prevents save-order race) Refactoring: - Extract duplicated rm-ai-ide → crow migration into PersistenceSupport - Add error logging to ConfigStore.loadConfig() decode failures Testing (15 new tests): - JSONStoreTests: empty creation, persistence, concurrency, corruption backup, file permissions, model round-trip - SessionRepositoryTests: CRUD, delete cascade regression, filtering - ConfigStoreTests: config round-trip, missing/corrupt files, permissions - Add CrowPersistenceTests target and `make test` Documentation: - Expand doc comments on JSONStore, SessionRepository, ConfigStore Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dhilgaertner
force-pushed
the
feature/crow-68-quality-pass-persistence
branch
from
50a2d0c to
8c2bed5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionRepository.delete()now cascades to terminals (was leaking orphaned records)JSONStore.mutate()holds the lock through disk write to prevent save-order race conditionrm-ai-ide→crowmigration into sharedPersistenceSupporthelperConfigStore.loadConfig()decode failures (was silently swallowing)make testtargetCloses #68
Test plan
make test— all 15 new CrowPersistence tests + 3 existing CrowCore tests passmake build— full app build succeeds with no regressions🤖 Generated with Claude Code