Quality pass: GitHub/GitLab integration#92
Merged
dhilgaertner merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
Refactoring, documentation, code review fixes, and testing for the provider detection, issue tracking, and PR status monitoring layer. - Fix pre-existing bug in ProviderManager URL parsing (split drops empty strings, so indices were off by 1) - Add error logging to 8 silent try? shell calls in IssueTracker - Add overlapping refresh guard to prevent concurrent polling cycles - Extract shared GitHub issue JSON parsing to deduplicate code - Move mapProjectStatus() to TicketStatus(projectBoardName:) initializer - Extract static parseTicketURLComponents() and reuse in markInReview() - Add doc comments to PRStatus enums, AssignedIssue fields, ProviderManager - Fix stale "Poll every 5 minutes" comment (actual interval is 60s) - Add GitLab warning in checkIssueClosed() (was silently returning false) - Add 25 new tests: ProviderManager (10), PRStatus (7), TicketStatus (5+) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dhilgaertner
force-pushed
the
feature/crow-74-quality-pass-git-integration
branch
from
db98c02 to
a1b0366
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #74
ProviderManagerURL parsing (splitdrops empty strings, indices were off by 1)try?shell calls inIssueTracker— failures now print diagnostic messages instead of silently returning empty resultsfetchGitHubIssues()/fetchDoneIssuesLast24h()mapProjectStatus()toTicketStatus(projectBoardName:)initializer on the enumparseTicketURLComponents()fromProviderManagerand reuse inmarkInReview()PRStatusenums,AssignedIssuefields,ProviderManagermethods, GraphQL queriescheckIssueClosed()(was silently returning false)CrowProviderandCrowCoreTest plan
make build— full app compiles with no new warningscd Packages/CrowCore && swift test— 15 tests pass (3 existing + 12 new)cd Packages/CrowProvider && swift test— 10 new tests pass🤖 Generated with Claude Code