Skip to content

Fix session not completing when linked issue is closed #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhilgaertner merged 1 commit into from
Apr 5, 2026
Merged

Fix session not completing when linked issue is closed #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Sources/Crow/App/IssueTracker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ final class IssueTracker {
syncInReviewSessions(issues: allIssues)

// Auto-complete sessions whose linked issue/PR is no longer open
await autoCompleteFinishedSessions(openIssues: allIssues)
await autoCompleteFinishedSessions(openIssues: allIssues.filter { $0.state == "open" })
}

// MARK: - GitHub
Expand Down Expand Up @@ -403,7 +403,11 @@ final class IssueTracker {
private func autoCompleteFinishedSessions(openIssues: [AssignedIssue]) async {
let openIssueURLs = Set(openIssues.map(\.url))

for session in appState.activeSessions {
let candidateSessions = appState.sessions.filter {
$0.id != AppState.managerSessionID &&
($0.status == .active || $0.status == .paused || $0.status == .inReview)
}
for session in candidateSessions {
guard let ticketURL = session.ticketURL else { continue }

// If the issue is still in the open list, it's not finished
Expand Down
Loading