Fix Ctrl+C and other control keys not working in terminal#78
Merged
dhilgaertner merged 2 commits intomainfrom Apr 5, 2026
Merged
Fix Ctrl+C and other control keys not working in terminal#78dhilgaertner merged 2 commits intomainfrom
dhilgaertner merged 2 commits intomainfrom
Conversation
Ctrl+key combinations were broken because the key event metadata sent to libghostty was incomplete. Control characters (e.g. \x03 for Ctrl+C) were passed as text, but Ghostty handles control-character mapping internally. Align key event construction with upstream Ghostty: set consumed_mods and unshifted_codepoint, strip control characters from text, add flagsChanged for modifier tracking, and add performKeyEquivalent to prevent macOS from intercepting Ctrl+key events. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dhilgaertner
force-pushed
the
feature/crow-49-ctrl-c-webserver
branch
from
f2285e6 to
d343a6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GhosttySurfaceViewkey handling with upstream Ghostty: properly setsconsumed_mods,unshifted_codepoint, strips control chars from text, addsflagsChangedandperformKeyEquivalentoverridesCloses #49
Test plan
sleep 100, press Ctrl+C — should interrupt the process🤖 Generated with Claude Code