Conversation
rad1092
deleted the
codex/add-synonym-definitions-in-schema_semantics_ko.json
branch
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff1668a3f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if term and term in question: | ||
| match = match_alias_to_column(term, columns, concepts) | ||
| mappings.append(match) | ||
| if match.status == "success" and match.matched_column: | ||
| normalized_question = normalized_question.replace(term, match.matched_column) |
There was a problem hiding this comment.
normalize_question_entities matches aliases with plain substring checks and then runs global str.replace, so terms that appear inside longer words are rewritten incorrectly. For example, with column 시군구명 and question 시군구명 별 ..., the canonical term 시군구 matches and replacement produces 시군구명명 ..., which then feeds a corrupted question into the prompt. This can silently degrade analysis whenever a concept term is a prefix/subsequence of another token.
Useful? React with 👍 / 👎.
1 participant
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task