Skip to content

Add postgresql backend#82

Open
mattyb wants to merge 3 commits into
r-lib:mainfrom
civisanalytics:postgresql_squash
Open

Add postgresql backend#82
mattyb wants to merge 3 commits into
r-lib:mainfrom
civisanalytics:postgresql_squash

Conversation

@mattyb

@mattyb mattyb commented Feb 13, 2019

Copy link
Copy Markdown

This PR creates a PostgreSQL backend for memoise

@codecov-io

codecov-io commented Feb 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #82 into master will decrease coverage by 8.5%.
The diff coverage is 89.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   77.37%   68.86%   -8.51%     
==========================================
  Files           5        6       +1     
  Lines         221      318      +97     
==========================================
+ Hits          171      219      +48     
- Misses         50       99      +49
Impacted Files Coverage Δ
R/cache_postgresql.R 89.69% <89.69%> (ø)
R/cache_s3.R 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1650ad7...86c6a6c. Read the comment docs.

@mattyb mattyb requested a review from jimhester February 17, 2020 17:39
@jimhester

Copy link
Copy Markdown
Member

Is there a reason you used RPostgreSQL for this instead of RPostgres? Also rather than a postgres specific database maybe it would make more sense to use the odbc package, so any odbc-compliant database could be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants