Remove merge code from indexers; Renaming and cleanup#6346
Open
nadav-govari wants to merge 4 commits intonadav/feature-split-mergesfrom
Open
Remove merge code from indexers; Renaming and cleanup#6346nadav-govari wants to merge 4 commits intonadav/feature-split-mergesfrom
nadav-govari wants to merge 4 commits intonadav/feature-split-mergesfrom
Conversation
nadav-govari
changed the title
nadav-govari
force-pushed
the
nadav/pr10
branch
from
9f05c4e to
047fd5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fully removes the merge code from the indexing service and pipelines. The only thing that remains is the merge policy, which is needed by the uploader to determine if splits are mature. Though they likely aren't, it's best kept like this for compatibility reasons.
How was this PR tested?
The entire feature branch was tested on a load-bearing cluster and worked successfully to merge splits.