Fix atom leak in JS_NewSymbol

[engsr6982]

This leak was introduced in commit 4a66289 when the public JS_NewSymbol API was first added. The function calls JS_NewAtom to create an atom from the description string, but never calls JS_FreeAtom after passing it to JS_NewSymbolFromAtom. This results in the atom's reference count never reaching zero, leaking memory for every symbol created via this C API.

[engsr6982]

Actions don't look good, I'll take another look.

[engsr6982]

I added JS_SetDumpFlags(rt, JS_DUMP_LEAKS | JS_DUMP_ATOM_LEAKS); to the new_symbol test case in api-test.c. The test output shows that there is indeed an atom leak here.

However, I'm not sure why adding JS_FreeAtom(ctx, atom); causes a segfault instead. Is this behavior by design, or is there something I'm missing about the atom lifecycle in JS_NewSymbol?

[saghul]

You are freeing the atom before you use it.