Open
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
SpertsyanKM
approved these changes
Apr 30, 2026
The previous commit renamed the onDeferredPurchaseCompleted override parameter to match the supertype's transaction name, but that reverted a deliberate review-driven rename (commit 801d40d) that aligned Android with iOS (RNQonversion.mm uses purchaseResult). Restore purchaseResult and silence the Kotlin override-mismatch warning with @Suppress instead of renaming. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Removing the @Suppress annotation. The override-vs-supertype param-name warning is the root-cause symptom of sandwich-sdk's QonversionEventsListener declaring 'transaction' while iOS and the rest of the RN bridge use 'purchaseResult'. That will be fixed at the source via a sandwich-sdk PR to rename the supertype param. After that lands and we bump io.qonversion:sandwich, this override will silently match. Until then, the warning is acceptable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the React Native deprecation warning from #439 in
android/src/main/java/com/qonversion/reactnativesdk/QonversionModule.kt:26.ActivityProvider.currentActivitygetter no longer referencesBaseJavaModule.getCurrentActivity()(deprecated in RN 0.80.0). Replacedthis@QonversionModule.currentActivitywithreactApplicationContext.currentActivity, which resolves toReactContext.getCurrentActivity()(a Java method, not deprecated). This silences both the deprecation warning and the Kotlin synthetic-property warning.The third warning from #439 (override-vs-supertype param-name mismatch on
onDeferredPurchaseCompleted) is the symptom ofsandwich-sdkdeclaring the supertype param astransactionwhile iOS and the RN bridge usepurchaseResult(cross-platform-aligned, see commit 801d40d). That will be addressed at the root via a sandwich-sdk PR renaming the supertype param; this PR intentionally leaves the warning in place.Single-file change, +1/-1.
Closes #439