fix(commons): sync tags to fields in add_tags() for report mode#478
Merged
fix(commons): sync tags to fields in add_tags() for report mode#478
Conversation
Move tags-to-fields merge from _prepare_result() (API-only) into Result.add_tags() via _sync_tags_to_fields() so tags appear in fields["tags"] for all modes including local report generation. Bump version to 5.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_prepare_result()(API-only) intoResult.add_tags()via_sync_tags_to_fields()fields["tags"]for all modes including local report generationProblem
In 5.1.0, tags were only merged into
fields["tags"]inside_prepare_result()which only runs in testops mode. In report mode,result.fieldsis serialized directly — tags were missing.Test plan
TestResultTagsFieldsMergetests verify automatic sync