fix: avoid crash for private market events without value#331
Open
saschabuehrle wants to merge 1 commit intopytr-org:masterfrom
Open
fix: avoid crash for private market events without value#331saschabuehrle wants to merge 1 commit intopytr-org:masterfrom
saschabuehrle wants to merge 1 commit intopytr-org:masterfrom
Conversation
Collaborator
|
Seems like a good bandaid. However, maybe we should generate a PPEventType.TAXES event with a value of 0 in that case. Would you mind sharing the (redacted) event from all_events.json that causes the issue? |
Collaborator
|
With #341 I have fixed an issue with private markets Vorabpauschale. Please check if it helps in your case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #322
Some private market timeline events (for example Vorabpauschale entries) have no monetary value. The exporter currently asserts on those events and aborts the whole export.
This change skips only the malformed private-market event, logs a warning, and continues exporting the remaining transactions. Added a regression test for this case.
Greetings, saschabuehrle