-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New Ray Serve tutorial #3709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New Ray Serve tutorial #3709
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3709
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Merge Blocking SEVsThere is 1 active merge blocking SEVs. Please view them below:
If you must merge, use This comment was automatically generated by Dr. CI and updates every 15 minutes. |
## Description Automatically exclude common directories (.git, .venv, venv, __pycache__) when uploading working_dir in runtime environment packages. At a minimum we need to exclude `.git/` because unlike the others, nobody includes .git/ in `.gitignore`. This causes Ray to throw a `ray.exceptions.RuntimeEnvSetupError` if your `.git` dir is larger than 512 MiB. I also updated the documentation in handling-dependencies.rst and improved the error message if the env exceeds the GCS_STORAGE_MAX_SIZE limit. ## Related issues N/A ## Additional information This PR pytorch/tutorials#3709 was failing to run because the PyTorch tutorials .git/ folder is huge. --------- Signed-off-by: Ricardo Decal <public@ricardodecal.com> Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com> Signed-off-by: Ricardo Decal <rdecal@anyscale.com> Co-authored-by: Ricardo Decal <public@ricardodecal.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
## Description Automatically exclude common directories (.git, .venv, venv, __pycache__) when uploading working_dir in runtime environment packages. At a minimum we need to exclude `.git/` because unlike the others, nobody includes .git/ in `.gitignore`. This causes Ray to throw a `ray.exceptions.RuntimeEnvSetupError` if your `.git` dir is larger than 512 MiB. I also updated the documentation in handling-dependencies.rst and improved the error message if the env exceeds the GCS_STORAGE_MAX_SIZE limit. ## Related issues N/A ## Additional information This PR pytorch/tutorials#3709 was failing to run because the PyTorch tutorials .git/ folder is huge. --------- Signed-off-by: Ricardo Decal <public@ricardodecal.com> Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com> Signed-off-by: Ricardo Decal <rdecal@anyscale.com> Co-authored-by: Ricardo Decal <public@ricardodecal.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
## Description Automatically exclude common directories (.git, .venv, venv, __pycache__) when uploading working_dir in runtime environment packages. At a minimum we need to exclude `.git/` because unlike the others, nobody includes .git/ in `.gitignore`. This causes Ray to throw a `ray.exceptions.RuntimeEnvSetupError` if your `.git` dir is larger than 512 MiB. I also updated the documentation in handling-dependencies.rst and improved the error message if the env exceeds the GCS_STORAGE_MAX_SIZE limit. ## Related issues N/A ## Additional information This PR pytorch/tutorials#3709 was failing to run because the PyTorch tutorials .git/ folder is huge. --------- Signed-off-by: Ricardo Decal <public@ricardodecal.com> Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com> Signed-off-by: Ricardo Decal <rdecal@anyscale.com> Co-authored-by: Ricardo Decal <public@ricardodecal.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
|
This looks sane to me, but let's make sure everything is passing. |
|
@AlannaBurke @svekars I've moved this PR out of draft. CI is blocked by approval, could a maintainer please trigger the tests? Thanks! |
|
It looks like there is an error: https://github.com/pytorch/tutorials/actions/runs/21602438372/job/62251972530?pr=3709#step:9:7717 |
|
@svekars the issue was that Please trigger the CI again to confirm that everything is fixed. |
|
Thanks for triggering @svekars ! It looks like a few tests were cancelled due to internal server errors. |
## Description Automatically exclude common directories (.git, .venv, venv, __pycache__) when uploading working_dir in runtime environment packages. At a minimum we need to exclude `.git/` because unlike the others, nobody includes .git/ in `.gitignore`. This causes Ray to throw a `ray.exceptions.RuntimeEnvSetupError` if your `.git` dir is larger than 512 MiB. I also updated the documentation in handling-dependencies.rst and improved the error message if the env exceeds the GCS_STORAGE_MAX_SIZE limit. ## Related issues N/A ## Additional information This PR pytorch/tutorials#3709 was failing to run because the PyTorch tutorials .git/ folder is huge. --------- Signed-off-by: Ricardo Decal <public@ricardodecal.com> Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com> Signed-off-by: Ricardo Decal <rdecal@anyscale.com> Co-authored-by: Ricardo Decal <public@ricardodecal.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
## Description Automatically exclude common directories (.git, .venv, venv, __pycache__) when uploading working_dir in runtime environment packages. At a minimum we need to exclude `.git/` because unlike the others, nobody includes .git/ in `.gitignore`. This causes Ray to throw a `ray.exceptions.RuntimeEnvSetupError` if your `.git` dir is larger than 512 MiB. I also updated the documentation in handling-dependencies.rst and improved the error message if the env exceeds the GCS_STORAGE_MAX_SIZE limit. ## Related issues N/A ## Additional information This PR pytorch/tutorials#3709 was failing to run because the PyTorch tutorials .git/ folder is huge. --------- Signed-off-by: Ricardo Decal <public@ricardodecal.com> Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com> Signed-off-by: Ricardo Decal <rdecal@anyscale.com> Co-authored-by: Ricardo Decal <public@ricardodecal.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
|
@svekars thanks for triggering the CI. The linter failed due to a trailing space; hopefully everything is ready to merge now :) |
Adds a new tutorial serving Pytorch models on Ray Serve.
This should be merged after #3694 since otherwise the new Ray version will break the existing Tune tutorial.
I will remove the [WIP] label after the Ray Serve team finishes their review.