Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends/arm/ethosu/compile_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def _default_system_config_and_memory_mode(
return resolved_system_config, resolved_memory_mode
if "ethos-u65" in target_lower:
resolved_system_config = (
"Ethos_U65_SYS_DRAM_Mid" if system_config is None else system_config
"Ethos_U65_High_End" if system_config is None else system_config
Comment thread
zingo marked this conversation as resolved.
)
resolved_memory_mode = "Sram_Only" if memory_mode is None else memory_mode
Comment on lines 49 to 53
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes the default system_config chosen for U65 targets; please add/adjust unit tests to lock in the expected default selection (e.g., asserting the generated compiler flags include the expected --system-config and --memory-mode when system_config/memory_mode are omitted).

Copilot uses AI. Check for mistakes.
return resolved_system_config, resolved_memory_mode
Expand Down
6 changes: 4 additions & 2 deletions backends/arm/scripts/aot_arm_compiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,8 @@ def forward(self, x):
"ethos-u55-64",
"ethos-u55-128",
"ethos-u55-256",
"ethos-u65-256",
"ethos-u65-512",
"ethos-u85-128",
"ethos-u85-256",
"ethos-u85-512",
Expand Down Expand Up @@ -628,13 +630,13 @@ def _get_args():
"--system_config",
required=False,
default=None,
help="System configuration to select from the Vela configuration file (see vela.ini). This option must match the selected target, default is for an optimal system 'Ethos_U55_High_End_Embedded'/'Ethos_U85_SYS_DRAM_High'",
help="System configuration to select from the Vela configuration file (see vela.ini). This option must match the selected target, default is for an optimal system 'Ethos_U55_High_End_Embedded'/ 'Ethos_U65_High_End' / 'Ethos_U85_SYS_DRAM_Mid'",
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --system_config help text uses inconsistent separators/spacing ("...Embedded'/ 'Ethos_U65_High_End' / 'Ethos_U85...") which makes it harder to read. Consider rewriting it as separate per-target defaults (U55/U65/U85) or using consistent punctuation.

Suggested change
help="System configuration to select from the Vela configuration file (see vela.ini). This option must match the selected target, default is for an optimal system 'Ethos_U55_High_End_Embedded'/ 'Ethos_U65_High_End' / 'Ethos_U85_SYS_DRAM_Mid'",
help="System configuration to select from the Vela configuration file (see vela.ini). This option must match the selected target. Defaults for optimal systems are: Ethos-U55: 'Ethos_U55_High_End_Embedded'; Ethos-U65: 'Ethos_U65_High_End'; Ethos-U85: 'Ethos_U85_SYS_DRAM_Mid'.",

Copilot uses AI. Check for mistakes.
)
parser.add_argument(
"--memory_mode",
required=False,
default=None,
help="Memory mode to select from the Vela configuration file (see vela.ini). Default is 'Shared_Sram' for Ethos-U55 targets and 'Sram_Only' for Ethos-U85 targets",
help="Memory mode to select from the Vela configuration file (see vela.ini). Default is 'Shared_Sram' for Ethos-U55 targets and 'Sram_Only' for Ethos-U65 and Ethos-U85 targets",
)
parser.add_argument(
"--config",
Expand Down
Loading