Update some tarfile.TarFile class attributes to be non-optional #15367
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following
tarfile.TarFileattributes are changed to non-optional:References
fileobjis set unconditionally in the constructor and never cleared:debug,dereference,encoding,format,ignore_zerosare all set as class level attributes, and only overwritten as instance attributes if the user passes a non-Noneoverride.Setting of class attributes:
Overwriting with constructor parameters:
Note:
This is my first PR on this project so I'm not sure about the expectations, let me know if I need to check additional versions supported by typeshed or if the PR should be split up somehow.