Emit end line/column in JSON format for span tracking #20734
Merged
+25
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Member
Author
|
Thanks @ilevkivskyi! A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, mypy gained the ability to output errors/notes as structured data in JSON format. This data, though, lacks the
end_lineandend_columninformation from mypy'sErrorTuple, which makes it harder to use for e.g. IDE integrations.This is a fairly simple PR to just expose those fields in the JSON. I updated the constructor of
MypyErrorto put the new arguments in the middle rather than at the end because I understand that this is an internal type, so we're free to make changes like this -- please correct me if I'm wrong here.I just updated the existing tests rather than adding new ones, hopefully this is fine!
A
cc @JelleZijlstra as reviewer of #11396