Skip to content

bpo-40243: Use numeric_changed for UCD.numeric#19457

Merged
serhiy-storchaka merged 7 commits intopython:mainfrom
wmeehan:bpo-40243
Feb 11, 2026
Merged

bpo-40243: Use numeric_changed for UCD.numeric#19457
serhiy-storchaka merged 7 commits intopython:mainfrom
wmeehan:bpo-40243

Conversation

@wmeehan
Copy link
Contributor

@wmeehan wmeehan commented Apr 10, 2020

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.

https://bugs.python.org/issue40243

This was causing `ucd_3_2_0.numeric()` to pick up only decimal
changes between Unicode 3.2.0 and the current version.
@ezio-melotti
Copy link
Member

This was causing ucd_3_2_0.numeric() to pick up only decimal changes between Unicode 3.2.0 and the current version.

@wmeehan: can you elaborate a bit more on this?

@serhiy-storchaka serhiy-storchaka self-requested a review February 28, 2024 17:34
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 18, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Thank you for your contribution, @wmeehan. I apologize that it took so long to do the review.

There was a reorganization in tests, so I rewrote them.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 11, 2026
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 11, 2026 20:57
@serhiy-storchaka serhiy-storchaka merged commit 3e0322f into python:main Feb 11, 2026
54 checks passed
@miss-islington-app
Copy link

Thanks @wmeehan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @wmeehan and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3e0322ff16f47caa3e273d453f007d3918b8ac80 3.14

@miss-islington-app
Copy link

Sorry, @wmeehan and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3e0322ff16f47caa3e273d453f007d3918b8ac80 3.13

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Feb 12, 2026
…19457)

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
(cherry picked from commit 3e0322f)

Co-authored-by: William Meehan <wmeehan@fb.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 12, 2026

GH-144731 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Feb 12, 2026
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Feb 12, 2026
…19457)

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
(cherry picked from commit 3e0322f)

Co-authored-by: William Meehan <wmeehan@fb.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 12, 2026

GH-144732 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 12, 2026
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Feb 12, 2026
…19457)

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
(cherry picked from commit 3e0322f)

Co-authored-by: William Meehan <wmeehan@fb.com>
serhiy-storchaka added a commit that referenced this pull request Feb 12, 2026
…44732)

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
(cherry picked from commit 3e0322f)

Co-authored-by: William Meehan <wmeehan@fb.com>
serhiy-storchaka added a commit that referenced this pull request Feb 12, 2026
…44731)

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
(cherry picked from commit 3e0322f)

Co-authored-by: William Meehan <wmeehan@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants