gh-148644: propagate PGO job exit code in PCbuild/build.bat#148645
gh-148644: propagate PGO job exit code in PCbuild/build.bat#148645rdesgroppes wants to merge 1 commit intopython:mainfrom
Conversation
Replace the `if "%clean%"=="false" (...)` block with a `goto :RunPgoJob` so the job runs outside any parenthesized block, where `%ERRORLEVEL%` is not subject to eager evaluation. Save the exit code before `call :Kill` resets it, then propagate it if non-zero.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
I guess so. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
After writing my caveats on the issue, I think we do want a |
2 participants
Replace the
if "%clean%"=="false" (...)block with agoto :RunPgoJobso the job runs outside any parenthesized block, where%ERRORLEVEL%is not subject to eager evaluation.Save the exit code before
call :Killresets it, then propagate it if non-zero.PCbuild/build.batdoes not propagate the PGO test run exit code #148644