Skip to content

GH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat compile-time version, not runtime #144740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hroncok wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat compile-time version, not runtime #144740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12c9611
GH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat comp…
hroncok Feb 12, 2026
0dca246
Fixup test class reference in news
hroncok Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/test/test_pyexpat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,9 @@ def test_set_maximum_amplification__amplification_not_exceeded(self):
self.assertIsNotNone(parser.Parse(payload, True))


@unittest.skipIf(expat.version_info < (2, 7, 2), "requires Expat >= 2.7.2")
@unittest.skipIf(not hasattr(expat.XMLParserType,
"SetAllocTrackerMaximumAmplification"),
"requires Python compiled with Expat >= 2.7.2")
class MemoryProtectionTest(AttackProtectionTestBase, unittest.TestCase):

# NOTE: with the default Expat configuration, the billion laughs protection
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Tests/2026-02-12-12-12-00.gh-issue-144739.-fx1tN.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
When Python was compiled with system expat older then 2.7.2 but tests run
with newer expat, still skip
:class:`!test.test_pyexpat.MemoryProtectionTest`.
Loading