compute-changes.py: Fix & test process_changed_files()
#144674
+158
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
requested review from
AA-Turner,
hugovk and
webknjaz
as code owners
webknjaz
approved these changes
Feb 11, 2026
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
I think this is fine for the initial effort. I might've missed something, reviewing from mobile, though. It'd be good to get an additional set of eyes on the PR.
hugovk
reviewed
Feb 11, 2026
| for p in LIBRARY_FUZZER_PATHS: | ||
| with self.subTest(p=p): | ||
| if p.is_dir(): | ||
| f = p / "comhad" |
Member
There was a problem hiding this comment.
What does "comhad" mean? Irish for "file"? https://en.wiktionary.org/wiki/comhad
Let's use an English word, maybe "example".
Member
Author
There was a problem hiding this comment.
What does "comhad" mean? Irish for "file"?
Yes, I had Irish on my mind:-)
I can change them :-(
Tá cosc ar an nGaeilge :-(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.