-
-
Notifications
You must be signed in to change notification settings - Fork 34k
gh-144490: Fix test_cppext on Windows #144628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings.
|
On Windows with Python built in debug mode, TestInteralCAPI of test_cppext fails the following warnings: |
|
!buildbot AMD64 Windows11 Non-Debug |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 8c9afa5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F144628%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
"AMD64 Windows11 Non-Debug PR" job is waiting for 2 hours for a Refleak job to complete. I will not wait longer for this job to run. Hugo asked for a fix for Tuesday to prepare Python releases. I tested my fix locally, so let me merge this fix. We will see later if my fix works on the buildbot. |
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings. (cherry picked from commit 245ba3d6cbef9fa0c0d55ab5e53f21a918e7b898)
Don't include pycore_backoff.h and pycore_cell.h on Windows, since they emit C++ compiler warnings.