Skip to content

gh-144623: Fix missing output uops in optimizer debug output #144617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 3 commits into from
Feb 9, 2026
Merged

gh-144623: Fix missing output uops in optimizer debug output #144617

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b1b295
fix missing out uops
cocolato Feb 9, 2026
2ac620a
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 9, 2026
11509a0
Delete Misc/NEWS.d/next/Core_and_Builtins/2026-02-09-11-57-29.gh-issu…
cocolato Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Python/optimizer_analysis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ dump_abstract_stack(_Py_UOpsAbstractFrame *frame, JitOptRef *stack_pointer)

static void
dump_uop(JitOptContext *ctx, const char *label, int index,
const _PyUOpInstruction *instr, JitOptRef *stack_pointer)
const _PyUOpInstruction *instr, JitOptRef *stack_pointer)
{
if (get_lltrace() >= 3) {
printf("%4d %s: ", index, label);
Expand All @@ -95,11 +95,24 @@ dump_uop(JitOptContext *ctx, const char *label, int index,
}
}

static void
dump_uops(JitOptContext *ctx, const char *label,
_PyUOpInstruction *start, JitOptRef *stack_pointer)
{
int current_len = uop_buffer_length(&ctx->out_buffer);
int added_count = (int)(ctx->out_buffer.next - start);
for (int j = 0; j < added_count; j++) {
dump_uop(ctx, label, current_len - added_count + j, &start[j], stack_pointer);
}
}

#define DUMP_UOP dump_uop
#define DUMP_UOPS dump_uops

#else
#define DPRINTF(level, ...)
#define DUMP_UOP(ctx, label, index, instr, stack_pointer)
#define DUMP_UOPS(ctx, label, start, stack_pointer)
#endif

static int
Expand Down Expand Up @@ -508,7 +521,7 @@ optimize_uops(
*(ctx->out_buffer.next++) = *this_instr;
}
assert(ctx->frame != NULL);
DUMP_UOP(ctx, "out", uop_buffer_length(&ctx->out_buffer) - 1, out_ptr, stack_pointer);
DUMP_UOPS(ctx, "out", out_ptr, stack_pointer);
if (!CURRENT_FRAME_IS_INIT_SHIM() && !ctx->done) {
DPRINTF(3, " stack_level %d\n", STACK_LEVEL());
ctx->frame->stack_pointer = stack_pointer;
Expand Down
Loading