gh-129745: Fix urlparse example to properly parse params#144461
Open
kovan wants to merge 1 commit intopython:mainfrom
Open
gh-129745: Fix urlparse example to properly parse params#144461kovan wants to merge 1 commit intopython:mainfrom
kovan wants to merge 1 commit intopython:mainfrom
Conversation
Changed the example from using 'scheme://' to 'http://' so that the params component is correctly parsed. The generic 'scheme' isn't in the list of schemes that support params, so the example was showing params remaining in the path rather than being extracted. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bedevere-app
bot
added
awaiting review
docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed the
urlparse()example from usingscheme://tohttp://so that the params component is correctly parsed.The generic
schemeisn't in the list of schemes that support parameter parsing (uses_params), so the previous example was showing params remaining in the path (path='/path;parameters') rather than being extracted (path='/path', params='parameters').Test plan
httpis inuses_paramsand correctly parses paramsmake checkpassesmake htmlbuilds successfully🤖 Generated with Claude Code
urllib.parse.urlparse()example doesn't parse theparams#129745📚 Documentation preview 📚: https://cpython-previews--144461.org.readthedocs.build/