gh-144316: Fix missing exception in _remote_debugging with debug=False#144442
Open
taegyunkim wants to merge 13 commits intopython:mainfrom
Open
gh-144316: Fix missing exception in _remote_debugging with debug=False#144442taegyunkim wants to merge 13 commits intopython:mainfrom
taegyunkim wants to merge 13 commits intopython:mainfrom
Conversation
7d1bb63 to
0f2d244
Compare
cffe58f to
66b060d
Compare
picnixz
reviewed
Feb 3, 2026
Misc/NEWS.d/next/Library/2026-02-03-19-57-41.gh-issue-144316.wop870.rst
Outdated
Show resolved
Hide resolved
Member
|
This macro is intended to add context to an exception not to be the actual cause of the error. Doing this will mask actual bugs in the code where we are not setting exceptions properly in places that should catch it and fail. Unfortunately this is not only is a partial fix but it will hide errors. The correct solution is finding the error paths that are not properly handling errors and fix there (and perhaps chain). |
Contributor
Author
|
@pablogsal Found |
picnixz
reviewed
Feb 4, 2026
Member
picnixz
left a comment
There was a problem hiding this comment.
I think we should instead add assert(PyErr_Occurred()) in _set_debug_exception_cause instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyErr_NoMemory()call whenPyMem_RawMalloc()returnedNULL.PyErr_Format()calls before callingset_exception_causemacroset_exception_causemacro to assert an error is set.RemoteUnwinder.get_stack_traceis missing exceptions on some error code paths #144316