Skip to content

gh-80667: fix case-sensitivity of some unicode literal escapes#107281

Merged
serhiy-storchaka merged 7 commits intopython:mainfrom
SnoopJ:bugfix/gh-80667_fix-case-sensitive-literal-escape
Feb 12, 2026
Merged

gh-80667: fix case-sensitivity of some unicode literal escapes#107281
serhiy-storchaka merged 7 commits intopython:mainfrom
SnoopJ:bugfix/gh-80667_fix-case-sensitive-literal-escape

Conversation

@SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented Jul 26, 2023

This PR is a partial fix for #80667, resolving inconsistent treatment of case in Unicode literal escape sequences. This changeset should be compatible with the changes in #101585 as well as named ranges that may be introduced in the future.

@SnoopJ
Copy link
Contributor Author

SnoopJ commented Jul 26, 2023

I did not realize when I wrote this patch last night that PyOS_strnicmp() existed, I've rewritten the patch to use it instead, avoiding the issues that were caused by the string copying approach. Ready for review.

@SnoopJ SnoopJ force-pushed the bugfix/gh-80667_fix-case-sensitive-literal-escape branch from 5b0156b to abd39e4 Compare July 26, 2023 15:59
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 12, 2026
@serhiy-storchaka serhiy-storchaka merged commit e66f4a5 into python:main Feb 12, 2026
55 checks passed
@miss-islington-app
Copy link

Thanks @SnoopJ for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2026
…ythonGH-107281)

Lookup for CJK ideograms and Hangul syllables is now case-insensitive,
as is the case for other character names.
(cherry picked from commit e66f4a5)

Co-authored-by: James <snoopjedi@gmail.com>
@miss-islington-app
Copy link

Sorry, @SnoopJ and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e66f4a5a9c7ce744030d6352bf5575639b1096cc 3.13

@bedevere-app
Copy link

bedevere-app bot commented Feb 12, 2026

GH-144753 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Feb 12, 2026
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Feb 12, 2026
…scapes (pythonGH-107281)

Lookup for CJK ideograms and Hangul syllables is now case-insensitive,
as is the case for other character names.
(cherry picked from commit e66f4a5)

Co-authored-by: James <snoopjedi@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 12, 2026

GH-144754 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 12, 2026
@SnoopJ SnoopJ deleted the bugfix/gh-80667_fix-case-sensitive-literal-escape branch February 12, 2026 17:05
serhiy-storchaka added a commit that referenced this pull request Feb 12, 2026
…GH-107281) (GH-144754)

Lookup for CJK ideograms and Hangul syllables is now case-insensitive,
as is the case for other character names.
(cherry picked from commit e66f4a5)

Co-authored-by: James <snoopjedi@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Feb 12, 2026
…GH-107281) (GH-144753)

Lookup for CJK ideograms and Hangul syllables is now case-insensitive,
as is the case for other character names.
(cherry picked from commit e66f4a5)

Co-authored-by: James <snoopjedi@gmail.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
…ythonGH-107281)

Lookup for CJK ideograms and Hangul syllables is now case-insensitive,
as is the case for other character names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants