Skip to content

Revert "fix(resolver): bypass cooldown for transitive deps when top-level pin exists#1156

Merged
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
LalatenduMohanty:fix/cooldown-exempt-versions
May 14, 2026
Merged

Revert "fix(resolver): bypass cooldown for transitive deps when top-level pin exists#1156
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
LalatenduMohanty:fix/cooldown-exempt-versions

Conversation

@LalatenduMohanty
Copy link
Copy Markdown
Member

This reverts commit dcd8a84.

Why

#1153 (comment)

…evel pin exists"

This reverts commit dcd8a84.

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty LalatenduMohanty requested a review from a team as a code owner May 14, 2026 18:34
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d8c2ca68-dba3-4389-b947-eb7afa0050bf

📥 Commits

Reviewing files that changed from the base of the PR and between db8a160 and 3da081c.

📒 Files selected for processing (2)
  • src/fromager/resolver.py
  • tests/test_cooldown.py
💤 Files with no reviewable changes (2)
  • src/fromager/resolver.py
  • tests/test_cooldown.py

📝 Walkthrough

Walkthrough

This PR simplifies the package cooldown bypass logic in the resolver. Previously, resolve_package_cooldown() would skip cooldown checks for transitive dependencies whenever a top-level exact version pin (==) existed elsewhere in the dependency graph. The implementation now restricts cooldown bypass to cases where the requirement being resolved is itself top-level with an exact pin. The corresponding test coverage for the transitive-dependency bypass behavior has been removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: reverting a previous fix that bypassed cooldown for transitive dependencies.
Description check ✅ Passed The description directly relates to the changeset by explaining this is a revert of a specific commit, with a reference to the issue discussion.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot added the ci label May 14, 2026
@mergify mergify Bot merged commit bd86c56 into python-wheel-build:main May 14, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants