Draft
Conversation
Author
|
@njsmith could you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182
maybe_read_from_IDLE_clientandmaybe_read_from_SEND_RESPONSE_serverreaders wait for concrete terminators and produce NEED_DATA events until that. After NEED_DATAmax_incomplete_event_sizelimit is checked.Here I'm adding consistent size limits for these events, that do not depend on chunking patterns.
To ensure that we need to reject complete
requestdata chunk if incompleterequest[:-1]already exceedsmax_incomplete_event_sizelimit.Practically
max_complete_event_size = max_incomplete_event_size + 1and enforced for "all or nothing" event readers.I've added failing test with the first commit and the fix in the second.