Change name of get_peer_name to attached_to in Element.#258
Open
TeresiaOlsson wants to merge 2 commits into
Open
Change name of get_peer_name to attached_to in Element.#258TeresiaOlsson wants to merge 2 commits into
TeresiaOlsson wants to merge 2 commits into
Conversation
gubaidulinvadim
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest to change the function name
get_peer_namein Element toattached_toto make it easier for the users to understand what this function does and make it clearer that it returns something which is different than doing peer.name and that's why there is a specific function for it.