Skip to content

feat: Add bandpass filtering#214

Merged
smlloyd merged 3 commits intomasterfrom
feat-add-bandpass
Feb 17, 2026
Merged

feat: Add bandpass filtering#214
smlloyd merged 3 commits intomasterfrom
feat-add-bandpass

Conversation

@smlloyd
Copy link
Copy Markdown
Member

@smlloyd smlloyd commented Feb 17, 2026


📚 Documentation preview 📚: https://aimbat--214.org.readthedocs.build/en/214/

Copilot AI review requested due to automatic review settings February 17, 2026 15:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.31%. Comparing base (b29dd9f) to head (bcb257f).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   93.18%   93.31%   +0.12%     
==========================================
  Files          32       33       +1     
  Lines        1599     1615      +16     
==========================================
+ Hits         1490     1507      +17     
+ Misses        109      108       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds bandpass-filter parameter plumbing across AIMBAT’s settings, models, typing layer, and ICCS instance creation, plus updates the lockfile to newer dependency versions.

Changes:

  • Introduce bandpass_apply, bandpass_fmin, bandpass_fmax in settings and event-parameter models, and pass them into pysmo’s ICCS.
  • Extend typing enums/type aliases and adjust typing tests for the new parameters (PEP 695 type aliases).
  • Update uv.lock (notably pysmo git rev and a few Python package bumps).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
uv.lock Updates locked dependency versions/URLs (including pysmo rev).
tests/test_typing.py Adjusts typing tests for PEP 695 aliases and new enum members; introduces some typing/ignore issues.
src/aimbat/lib/typing.py Adds bandpass-related EventParameter members and converts aliases to PEP 695 type syntax.
src/aimbat/lib/models.py Adds bandpass fields to AimbatEventParametersBase; switches several defaults to default_factory; adds validator mixin to table model.
src/aimbat/lib/iccs.py Threads new bandpass parameters into ICCS(...) construction.
src/aimbat/lib/_validators.py Adds shared pydantic validator ensuring bandpass_fmax > bandpass_fmin.
src/aimbat/config.py Adds bandpass defaults/constraints; changes db_url to computed in an after validator; mixes in frequency-range validator.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_typing.py Outdated
Comment thread tests/test_typing.py Outdated
def set_from_strenum(enum: StrEnum) -> set[str]:
def set_from_strenum(enum: EnumType) -> set[TypeAliasType]:

return set([member.value for member in enum]) # type: ignore
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The # type: ignore here is very broad; with warn_unused_ignores = true it can also cause CI to fail if mypy doesn’t actually emit an error on this line. Prefer to adjust the parameter type (e.g., type[StrEnum]) / expression so mypy can type-check it, or use a targeted # type: ignore[<code>] only if strictly necessary.

Copilot uses AI. Check for mistakes.
Comment thread src/aimbat/config.py Outdated
Comment thread src/aimbat/lib/_validators.py
smlloyd and others added 2 commits February 17, 2026 15:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@smlloyd smlloyd merged commit e22128c into master Feb 17, 2026
23 checks passed
@smlloyd smlloyd deleted the feat-add-bandpass branch February 17, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants