Fix/re-enable quoted_insert: use self.evt.data#17
Merged
Conversation
Reverts pypy@a59f338cc7b6c. Fixes: File "/usr/lib/python3.7/cmd.py", line 126, in cmdloop line = input(self.prompt) File "…/src/pyrepl/pyrepl/readline.py", line 229, in raw_input ret = reader.readline(startup_hook=self.startup_hook) File "…/src/pyrepl/pyrepl/reader.py", line 605, in readline self.handle1() File "…/src/pyrepl/pyrepl/reader.py", line 588, in handle1 self.do_cmd(cmd) File "…/src/pyrepl/pyrepl/reader.py", line 535, in do_cmd cmd.do() File "…/src/pyrepl/pyrepl/commands.py", line 373, in do r.insert((self.event + r.console.getpending().data) * r.get_arg()) TypeError: can't concat str to bytearray
Collaborator
Author
|
@antocuni |
Collaborator
Author
|
Enabled it now (after access was granted to my request), but https://travis-ci.org/pypy/pyrepl/requests says:
|
Collaborator
Author
|
@antocuni If this is not fixed until tomorrow I'll consider moving it back to the pdbpp org. |
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 61.11% 61.42% +0.31%
==========================================
Files 22 22
Lines 2232 2237 +5
Branches 325 325
==========================================
+ Hits 1364 1374 +10
+ Misses 754 749 -5
Partials 114 114
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts a59f338cc7b6c.
Fixes:
(happens with
Ctrl-q+ something in pdbpp prompt)Taken out of #2.