Allow AdminUnknownFixes for Angel's + Py#166
Open
Admin-Unknown wants to merge 1 commit intopyanodon:mainfrom
Open
Allow AdminUnknownFixes for Angel's + Py#166Admin-Unknown wants to merge 1 commit intopyanodon:mainfrom
Admin-Unknown wants to merge 1 commit intopyanodon:mainfrom
Conversation
Made-with: Cursor
Author
|
Have tried the change locally and successfully loading into a game |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: AdminUnknownFixes merges former PyCoalTBaA / PyPPTBaA (
pyppatba) bridge work for Factorio 2.0 + Angel's + Py.Change A: Skip the
Please install PyCoal Touched By an Angelerror()whenmods[AdminUnknownFixes]is set (seeprototypes/functions/compatibility.lua).Rationale: Legacy PyCoalTBaA is 1.1-era; the Angel's + Py bridge for 2.0 lives in AdminUnknownFixes. Players with AdminUnknownFixes should not need an empty PyCoalTBaA stub.
Safety: If the real PyCoalTBaA mod is enabled,
mods[PyCoalTBaA]is true and the error path is unchanged.Reference: Upstream PR checklist
Made with Cursor