Skip to content

time related functions - implementation cleanup#983

Open
dwrobel wants to merge 1 commit intopxscene:masterfrom
dwrobel:time-related-functions
Open

time related functions - implementation cleanup#983
dwrobel wants to merge 1 commit intopxscene:masterfrom
dwrobel:time-related-functions

Conversation

@dwrobel
Copy link
Copy Markdown
Contributor

@dwrobel dwrobel commented Mar 21, 2018

time related functions - implementation cleanup

 - introduces the new common implementation of time-related functions
   for all platforms supporting c++11,
 - try to synchronize legacy (non c++11) time implementations,
 - fixes legacy (non c++11) implementation of pxSleepMS(),
 - introduces new: void pxSleepUS(uint64_t usToSleep); function,

 - fixes pxTimerNativeTest failure:
    /Users/travis/build/pxscene/pxCore/tests/pxScene2d/test_pxTimerNative.cpp:37: Failure
    Value of: (int)(endTime - startTime) == TEST_TIME
      Actual: false
    Expected: true
    [  FAILED  ] pxTimerNativeTest.pxTimerNativeTestS (2000 ms),

 - start using pxSleep*() in wayland_egl/pxWindowNative.cpp backend,

 - even pacing on wayland_egl backend.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2018

Codecov Report

Merging #983 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
+ Coverage    62.5%   62.53%   +0.03%     
==========================================
  Files         128      127       -1     
  Lines       17927    17920       -7     
==========================================
+ Hits        11206    11207       +1     
+ Misses       6721     6713       -8
Impacted Files Coverage Δ
src/pxTimer.h 100% <100%> (ø)
examples/pxScene2d/src/pxResource.cpp 81.25% <0%> (-0.25%) ⬇️
examples/pxScene2d/src/pxScene2d.cpp 70.7% <0%> (ø) ⬆️
src/rtFileDownloader.cpp 71.98% <0%> (+0.35%) ⬆️
src/rtHttpCache.cpp 53.58% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7c773...d40fb09. Read the comment docs.

@dwrobel dwrobel force-pushed the time-related-functions branch from ffa10a9 to 49e4db6 Compare April 11, 2018 09:28
@conniefry conniefry requested a review from mfiess April 25, 2018 15:28
 - introduces new common implementation of time related functions
   for all platforms supporting c++11,
 - try to synchronize legacy (non c++11) time implementations,
 - fixes legacy (non c++11) implementation of pxSleepMS(),
 - introduces new: void pxSleepUS(uint64_t usToSleep); function,

 - fixes pxTimerNativeTest failure:
    /Users/travis/build/pxscene/pxCore/tests/pxScene2d/test_pxTimerNative.cpp:37: Failure
    Value of: (int)(endTime - startTime) == TEST_TIME
      Actual: false
    Expected: true
    [  FAILED  ] pxTimerNativeTest.pxTimerNativeTestS (2000 ms),

 - start using pxSleep*() in wayland_egl/pxWindowNative.cpp backend.
@dwrobel dwrobel force-pushed the time-related-functions branch from 49e4db6 to d40fb09 Compare May 8, 2018 10:17
@mfiess
Copy link
Copy Markdown
Contributor

mfiess commented Sep 6, 2018

Let's leave the original file unmodified, but we can have a cmake option to using the new C++11 syntax (chrono) if configured. Otherwise we use the current files (as is). We can discuss in our next meeting.

Copy link
Copy Markdown
Contributor

@mfiess mfiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave the original file unmodified, but we can have a cmake option to using the new C++11 syntax (chrono) if configured. Otherwise we use the current files (as is). We can discuss in our next meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants