video updates for clipping and play/pause transit#12
Open
madanagopalt wants to merge 2 commits intopxscene:masterfrom
Open
video updates for clipping and play/pause transit#12madanagopalt wants to merge 2 commits intopxscene:masterfrom
madanagopalt wants to merge 2 commits intopxscene:masterfrom
Conversation
Contributor
|
have you tested this? On xi3 aamp doesn't send state 8 when playback starts, it's this.playing() in onPlaybackStarted that moves player to Playing |
Contributor
Author
|
Yes, tested in xi6
…On Sat, 25 Apr 2020, 02:55 Nikita Poltorapavlo, ***@***.***> wrote:
have you tested this? On xi3 aamp doesn't send state 8 when playback
starts, it's *this.playing()* in onPlaybackStarted that moves player to
Playing
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXFSOL4JYELN4RGTZS5423ROH7UVANCNFSM4MNDBRCA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.