Skip to content

Fix PVSystem module_type docstring default#2713

Open
r0hansaxena wants to merge 2 commits intopvlib:mainfrom
r0hansaxena:fix-2634
Open

Fix PVSystem module_type docstring default#2713
r0hansaxena wants to merge 2 commits intopvlib:mainfrom
r0hansaxena:fix-2634

Conversation

@r0hansaxena
Copy link
Contributor

  • Closes pvlib.pvsystem.PVSystem states wrong default for module_type #2634
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The module_type parameter in PVSystem is documented as having a default value of 'glass_polymer', but the actual default is None. This PR corrects the docstring to reflect the actual default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pvlib.pvsystem.PVSystem states wrong default for module_type

1 participant