Skip to content

feat: add journey ID to Slack notifications #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puzza007 merged 1 commit into from
Apr 1, 2026
Merged

feat: add journey ID to Slack notifications #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions athop_transaction_scraper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ def send_slack_notification(
"elements": [
{
"type": "mrkdwn",
"text": f"Transaction ID: {txn.cardtransactionid} | Type: {txn.transaction_type_description}",
"text": f"Transaction ID: {txn.cardtransactionid} | Journey: {txn.journey_id} | Type: {txn.transaction_type_description}",
}
],
},
Expand Down Expand Up @@ -620,7 +620,7 @@ def _check_new_transactions_for_mismatch(
cursor = conn.execute(
"""
SELECT cardtransactionid, transaction_type_description,
transactiondatetime, location
transactiondatetime, location, journey_id
FROM transactions
WHERE card_id = ?
AND transaction_type_description IN ('Tag on', 'Tag off')
Expand All @@ -636,10 +636,10 @@ def _check_new_transactions_for_mismatch(
if len(transactions) < 2:
return

current_txn_id, current_type, current_time, current_location = transactions[
current_txn_id, current_type, current_time, current_location, current_journey_id = transactions[
0
]
prev_txn_id, prev_type, prev_time, prev_location = transactions[1]
prev_txn_id, prev_type, prev_time, prev_location, prev_journey_id = transactions[1]

# Check for pattern break: same type twice in a row
if current_type == prev_type:
Expand Down Expand Up @@ -673,9 +673,11 @@ def _check_new_transactions_for_mismatch(
current_type,
current_time,
current_location,
current_journey_id,
prev_type,
prev_time,
prev_location,
prev_journey_id,
missing_action,
)

Expand Down Expand Up @@ -706,9 +708,11 @@ def _send_mismatch_notification(
current_type: str,
current_time: str,
current_location: str,
current_journey_id: str,
prev_type: str,
prev_time: str,
prev_location: str,
prev_journey_id: str,
missing_action: str,
) -> None:
"""Send Slack notification for tap mismatch."""
Expand Down Expand Up @@ -746,11 +750,11 @@ def _send_mismatch_notification(
"fields": [
{
"type": "mrkdwn",
"text": f"*Previous Transaction:*\n{prev_time}\n{prev_type} at {prev_location}",
"text": f"*Previous Transaction:*\n{prev_time}\n{prev_type} at {prev_location}\nJourney: {prev_journey_id}",
},
{
"type": "mrkdwn",
"text": f"*Current Transaction:*\n{current_time}\n{current_type} at {current_location}",
"text": f"*Current Transaction:*\n{current_time}\n{current_type} at {current_location}\nJourney: {current_journey_id}",
},
],
},
Expand Down
Loading