feat(moves): rivet variant integration in verify/enumerate (Track E commit 6/8)#173
Open
feat(moves): rivet variant integration in verify/enumerate (Track E commit 6/8)#173
Conversation
Promotes the v0.7.x line to a tagged release. Headlines: - Track A v0.7.0 (IRQ-aware hierarchical RTA + Lean theorems) - Track A v0.7.1 (PIP/PCP blocking) - Track B v0.7.x foundation (variant contract spec + spar-variants consumer crate) - v0.7.x verification infrastructure: Lean + Bazel + proptest CI gates (#135), Kani harnesses (#136), cargo-fuzz (#138), criterion benchmarks (#137) Track D Phase 1 (TSN/WCTT) and Track E commits 1-4 are also on main at the time of this tag and ship in the resulting binaries; they will be advertised as v0.8.0 features when Track E is fully closed. Cargo.toml workspace version + vscode-spar/package.json bumped to 0.7.1. CHANGELOG.md created (Keep a Changelog format). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ommit 6/8) Wires spar-variants (Track B v0.7.x consumer crate, #162) into spar moves verify and spar moves enumerate. Both commands now accept --variant NAME (implicit; shells out to rivet) and --variant-context PATH (explicit; reads the JSON blob directly per the v1 contract). Variant filter is applied before overlay validation: items not in the selected variant are dropped from the analysis surface, matching the contract's intersection semantics. Output includes variant + feature model hash for audit trail. New requirement: REQ-MIGRATION-008. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--variant NAMEand--variant-context PATHflags to bothspar moves verifyandspar moves enumerate, per the v1 contract indocs/contracts/rivet-spar-variant-v1.md. The flags are mutually exclusive; explicit form accepts a filesystem path or-for stdin; implicit form shells out torivet resolve --variant NAME --format spar-context-json(located via$RIVET_BINthen$PATH).spar-variants(Track B v0.7.x consumer crate, PR feat(variants): spar-variants consumer crate for rivet variant context v1 (Track B commit 1) #162) into the move-oracle pipeline. Newvariants_bridgemodule providesHasBindingIdentityadapters forComponentInstanceand a non-mutatingVariantScopewrapper that exposes lookup-time accessors over the(SystemInstance, VariantContext)pair so dropped components are excluded from--component/--toresolution and from the candidate-target set inenumerate— without rebuilding the instance.variant+feature_model_hashfields for the audit trail; text output prefixes the summary line with(variant=<name>).REQ-MIGRATION-008andTEST-MOVES-VARIANTrivet artifacts; clear errors for the rivet-not-found, unknown-version, mutually-exclusive-flags, and dropped-by-variant cases.Test plan
cargo build --workspacecleancargo test --workspacegreen (all crates passing, including 8 new tests incrates/spar-cli/tests/moves_variant.rsand 4 new unit tests invariants_bridge::tests)cargo clippy --workspace --all-targets -- -D warningscleancargo fmt --all -- --checkcleanrivet validatePASS (91 pre-existing INFO-level schema warnings unrelated to this commit)moves_verifyand 10moves_enumerateintegration tests still pass — variant flags are additiveSPAR_VARIANT_TEST_RIVET_OUTPUTtest seam (env var that bypasses the actual rivet binary; production builds never set it)🤖 Generated with Claude Code