Skip to content

soc_event_generator: preserve r_err set on concurrent APB read race #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flaviens wants to merge 1 commit into
base: master
Choose a base branch
from
Open

soc_event_generator: preserve r_err set on concurrent APB read race #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions rtl/pulp_soc/soc_event_generator.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,6 @@ module soc_event_generator #(
r_err = 'h0;
end
else begin
for (int i=0;i<EVNT_NUM;i++)
if(s_err[i])
r_err[i] = 1'b1;
r_apb_events = 'h0;
if (PSEL && PENABLE && PWRITE) begin
case (s_apb_addr)
Expand Down Expand Up @@ -341,6 +338,12 @@ module soc_event_generator #(
r_err[255:224] = 'h0;
endcase // s_apb_addr
end
// Sticky-set per-source error bits AFTER any APB read-clear so
// that an event firing on the same cycle as the read survives.
// Set wins over clear in the same-cycle race.
for (int i=0;i<EVNT_NUM;i++)
if(s_err[i])
r_err[i] = 1'b1;
end
end //always

Expand Down
Loading