Refactor string helpers to have less monkey patching#227
Open
mvz wants to merge 8 commits into
Open
Conversation
Member
mvz
commented
May 16, 2026
mvz
commented
- Copy string transform helpers to new TextTransformer module
- Delegate string extension methods to PublifyCore::TextTransformer
- Deprecate String#to_permalink monkeypatch and replace calls to it
- Make deprecation message about PublifyCore instead of about Rails
- Deprecate String#to_url monkeypatch and replace calls to it
- Store the deprecator in the PublifyCore module
- Spec that String#to_url and String#to_permalink are really deprecated
- Deprecate String#strip_html monkey-patch and replace calls to it
This also hides the deprecation messages given off by the tested calls.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| string = string.tr(key.join, value) | ||
| end | ||
| string = string.tr("'", "-") | ||
| to_url(string.gsub(/<[^>]*>/, "")) |
| string = string.tr(key.join, value) | ||
| end | ||
| string = string.tr("'", "-") | ||
| to_url(string.gsub(/<[^>]*>/, "")) |
Member
Author
|
Rails has its own methods that provide this functionality. Those methods will be more hardened and we should use them instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.