Feat: Add additional virtual keywords to wasm base.#444
Merged
mpwarres merged 3 commits intoproxy-wasm:mainfrom Jul 31, 2025
Merged
Feat: Add additional virtual keywords to wasm base.#444mpwarres merged 3 commits intoproxy-wasm:mainfrom
mpwarres merged 3 commits intoproxy-wasm:mainfrom
Conversation
rachgreen33
requested review from
PiotrSikora,
leonm1,
martijneken and
mpwarres
as code owners
mpwarres
requested changes
Jul 28, 2025
Contributor
mpwarres
left a comment
mpwarres
left a comment
There was a problem hiding this comment.
Thanks for upstreaming this!
rachgreen33
force-pushed
the
wasm_virtual
branch
from
f658795 to
affb22a
Compare
Signed-off-by: Rachel Green <rachgreen@google.com>
…etting. Signed-off-by: Rachel Green <rachgreen@google.com>
…n a build setting. Signed-off-by: Rachel Green <rachgreen@google.com>
rachgreen33
force-pushed
the
wasm_virtual
branch
from
affb22a to
31fb756
Compare
mpwarres
approved these changes
Jul 31, 2025
Contributor
mpwarres
left a comment
mpwarres
left a comment
There was a problem hiding this comment.
LGTM assuming CI passes. Once this is in, we will need to make some trivial changes in Envoy to adjust to this when we update its dependency to the latest proxy-wasm-cpp-host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.