fix: dashboard loading flash + updated screenshots#8
Merged
Conversation
Dashboard: - Add initialLoaded state gate so the welcome card only renders after the first get_saved_miners fetch completes. Previously, the welcome screen flashed briefly on every app launch (even with miners saved) because savedMiners starts as [] and the fetch takes a few seconds. Now shows a centered "Loading miners..." spinner until data arrives. Screenshots: - Updated existing screenshots to reflect current UI (Dashboard with ASIC/Mobile stats split, updated Alert Screen, Miner Detail, Miner Page Card/Grid views) - Added new screenshots: Mobile Miner Card view, Mobile Miner Grid view, Mobile Detail (Remote Control panel), Pool View (unified ASIC+Mobile pool matches) README: - Uncommented mobile miner screenshot placeholders and pointed them at the actual filenames (Mobile Miner Card.png, Mobile Miner Grid.png, Mobile Detail.png) - Added Pool View screenshot under Pool Management section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for v1 launch quality:
1. Dashboard welcome screen flash (bug fix)
On app launch, the dashboard showed the "Welcome to PoPManager" card for ~2 seconds even when miners were already configured, because
savedMinersinitializes as[]and the firstget_saved_minersfetch takes a moment. The zero-state checktotalCount === 0 && mobileCount === 0evaluated true during that window, causing a flash.Fix: Added
initialLoadedstate that startsfalseand flips totrueafter the firstget_saved_minersresponse (success or error). The render now has three branches:!initialLoaded→ centered spinner with "Loading miners..."initialLoaded && totalCount === 0 && mobileCount === 0→ welcome card2. Screenshots updated for v1
Updated existing screenshots (reflect current UI after mobile miners restructure):
Added new screenshots:
Mobile Miner Card.png— Mobile Miners card viewMobile Miner Grid.png— Mobile Miners grid/table viewMobile Detail.png— Mobile Miner Remote Control panelPool View.png— Pool detail showing unified ASIC + Mobile miner matchesREADME updated:
Verification
npx tsc --noEmit— cleanFiles changed