add Timer decorator support partial function#858
Open
dafu-wu wants to merge 1 commit intoprometheus:masterfrom
Open
add Timer decorator support partial function#858dafu-wu wants to merge 1 commit intoprometheus:masterfrom
dafu-wu wants to merge 1 commit intoprometheus:masterfrom
Conversation
2496d0e to
7476158
Compare
Signed-off-by: 吴成义 <wuchengyi2006@163.com>
Member
|
Thank you for the PR! |
Author
|
ok, I tried to submit a pr in the decorator. |
Author
|
Will this maybe as a side-effect solve issues with the decorator making an function untyped? (example attached) Currently I've solved this via a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we use time to decorate a partial function, I get an cannot decorate partial function error.
Should we use timer to support partial functions @hynek @csmarchbanks ? I thought it should be added and tried to add the relevant code.