Improve cyclomatic complexity#842
Open
ilya-anashkin wants to merge 2 commits intoprometheus:masterfrom
Open
Conversation
Member
csmarchbanks
left a comment
There was a problem hiding this comment.
Thank you for your contribution, I am not sure if this is an improvement over the old code, generally lowering cyclomatic complexity isn't a goal in and of itself, the goal is the most readable code. I think some of these changes help with readability, e.g. the change to registry.py, but not all of them.
|
|
||
| if labels is None: | ||
| labels = [] | ||
| elif value is not None: |
Member
There was a problem hiding this comment.
I find the old logic to be clearer. It was clearly a check at the very beginning to make sure the input was valid, then we assigned a default value. Now we are doing both at the same time which IMO is harder to understand.
emgas2022
approved these changes
Nov 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Using the example of my PR, I would like to show that the library needs to improve its cyclomatic complexity.
I tested with the utility radon
My changes