mark_process_dead: avoid error with bad env#768
Open
romuald wants to merge 1 commit intoprometheus:masterfrom
Open
mark_process_dead: avoid error with bad env#768romuald wants to merge 1 commit intoprometheus:masterfrom
romuald wants to merge 1 commit intoprometheus:masterfrom
Conversation
When the multiprocess environemnt is not properly set-up (missing environment variable) and mark_process_dead is called, the method raises an error on path.join() because the path is None which may be problematic This commit simply ignores the cleanup when the variable is not present Signed-off-by: Romuald Brunet <romuald@gandi.net>
romuald
force-pushed
the
mark_process_dead-without-env
branch
from
1fbdd40 to
d8d4248
Compare
csmarchbanks
reviewed
Feb 9, 2022
Member
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Thanks!
My initial reaction is that the error is actually a good thing though as it tells a user that they should fix their environment. At a minimum it seems like some sort of warning should be output?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the multiprocess environemnt is not properly set-up (missing
environment variable) and mark_process_dead is called, the method raises
an error on path.join() because the path is None which may be
problematic
This commit simply ignores the cleanup when the variable is not present
Context
We are using the same library for multiprocess and non-multiprocess setups.
While the setup is obviously wrong on our part (adding
mark_process_deadusingatexit). I thought that check in prometheus_client would be nice addition if anyone would get in the same pitfall