Open
Conversation
csmarchbanks
force-pushed
the
build-native-histograms
branch
from
d9708f3 to
7f01fd3
Compare
csmarchbanks
force-pushed
the
build-native-histograms
branch
from
7f01fd3 to
8f5698b
Compare
Initial support for allowing users to create native histograms. The initial implementation directly exposes the initial schema version rather than a factor, and we can provide guidance for choosing a good initial schema. If too many buckets will be created then resolution can be reduced, but in the current implementation the other reduction techniques (increasing zero bucket width, resets, etc...) are not yet implemented. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
csmarchbanks
force-pushed
the
build-native-histograms
branch
from
8f5698b to
64414de
Compare
Member
Author
|
@krajorama Would you be willing to take a look at this sometime? I tried to describe the differences I made compared to say client_golang, but let me know if you have questions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial support for allowing users to create native histograms. The initial implementation directly exposes the initial schema version rather than a factor, and we can provide guidance for choosing a good initial schema. If too many buckets will be created then resolution can be reduced, but in the current implementation the other reduction techniques (increasing zero bucket width, resets, etc...) are not yet implemented.
Depends on #1087 for the actual exposition
Part of #918