Add debug flag&handler for request#1050
Open
alex-ak1 wants to merge 5 commits intoprometheus:masterfrom
Open
Conversation
Signed-off-by: alex-ak1 <alex_ak1@mail.ru>
Signed-off-by: alex-ak1 <alex_ak1@mail.ru> Signed-off-by: alex-ak1 <alex_ak1@mail.ru>
Signed-off-by: alex-ak1 <alex_ak1@mail.ru>
Signed-off-by: alex-ak1 <alex_ak1@mail.ru>
Signed-off-by: alex-ak1 <alex_ak1@mail.ru>
csmarchbanks
reviewed
Aug 2, 2024
Member
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Since it has now been a couple people who have asked for this I am ok with the feature. Just a couple comments, some docstring would be nice as well so someone knows what it does.
| """Log nothing.""" | ||
|
|
||
|
|
||
| class _PrintHandler(WSGIRequestHandler): |
Member
There was a problem hiding this comment.
I think we could just use WSGIRequestHandler instead of creating a new handler. It will log by default.
| client_capath: Optional[str] = None, | ||
| protocol: int = ssl.PROTOCOL_TLS_SERVER, | ||
| client_auth_required: bool = False, | ||
| debug: bool = False |
Member
There was a problem hiding this comment.
Rather than just a debug flag, I wonder if we should let users specify the handler_class they are interested in using. That would be more flexible than having flags for everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parameter
debug: boolforstart_wsgi_serverandstart_http_server.If debug=True wsgi server prints every request to console.
Related to #925