test: validate Micrometer vanilla compatibility#2121
Draft
zeitlinger wants to merge 2 commits into
Draft
Conversation
This was referenced May 18, 2026
zeitlinger
force-pushed
the
validation/typed-descriptor-micrometer-2094
branch
from
921c00b to
1f435ae
Compare
zeitlinger
changed the title
zeitlinger
force-pushed
the
validation/typed-descriptor-micrometer-2094
branch
2 times, most recently
from
e97d666 to
c61d03d
Compare
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger
force-pushed
the
validation/typed-descriptor-micrometer-2094
branch
from
c61d03d to
8cdb60b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft validation PR for the unmodified Micrometer compatibility story.
This intentionally does not depend on #2114. Vanilla Micrometer does not use
the typed descriptor API and does not implement the #1800 registration metadata
hooks, so this PR validates the patch-compatible path independently of typed
descriptors.
This validates upstream
micrometer-metrics/micrometer@mainagainst:main, which already includes fix: restore legacy suffix compatibility #2100.PrometheusNaming.sanitizeMetricName()#2124 reserved suffix stripping inPrometheusNaming.sanitizeMetricName().Local validation:
mise run lintMICROMETER_DIR=/tmp/micrometer-compat-vanilla-2124 mise run micrometer:test